kunwp1 opened a new pull request, #5609:
URL: https://github.com/apache/texera/pull/5609
### What changes were proposed in this PR?
Backport of #5565 ("fix(frontend): clean up websocket state when returning
to the
dashboard") to `release/v1.2`.
Applies as a clean `git cherry-pick -x` of the merged squash commit
`ad10b7f2b` — no
conflicts and no prerequisite chain (unlike the #5280 backport in #5602).
Frontend-only:
14 files changed, 391 insertions, 2 deletions, identical to the original.
For the full change description see #5565. In brief: websocket-derived
front-end state
(the connection, plus execution status, console output, and results built
from its
events) lives in singletons outside the workspace and was never torn down
when returning
to the dashboard or switching computing units, so stale state carried over.
This tears
that state down in `WorkspaceComponent.ngOnDestroy()` and clears it again on
a
computing-unit switch.
### Any related issues, documentation, discussions?
Backports #5565 (which closes #3120 on `main`). Related: #3093.
### How was this PR tested?
This is a backport with no changes beyond the single cherry-picked commit,
so it relies
on the existing tests carried over from #5565 (added `*.spec.ts` cases across
`computing-unit-status`, `workspace.component`, `execute-workflow`,
`workflow-console`,
`workflow-result`, `result-panel`, and `workflow-websocket`).
Backport fidelity was verified locally: after the cherry-pick, every file
touched by
#5565 is byte-identical to its state on `main` at the merged commit
(`ad10b7f2b`), and
`release/v1.2` had no independent changes to any of those files.
Full compile and unit-test runs are left to CI.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
