lie18uci opened a new pull request, #5633:
URL: https://github.com/apache/texera/pull/5633

   ### What changes were proposed in this PR?
   
   This PR updates GitVersionControlLocalFileStorage.deleteRepo to close the 
stream returned by Files.walk(directoryPath) using try-with-resources.
   
   Files.walk(...) returns a closeable stream backed by directory resources. 
Wrapping it in try-with-resources ensures the stream is closed properly even if 
traversal or deletion throws.
   
   This keeps the existing deletion behavior unchanged while fixing the stream 
lifecycle.
   
   ### Any related issues, documentation, discussions?
   
   Closes #5548
   
   ### How was this PR tested?
   
   Verified the code change locally by inspecting the diff.
   
   Attempted to run:
   
   sbt "scalafixAll --check"
   
   but the local check failed because jOOQ code generation could not complete 
in my local setup. The error was:
   
   JOOQ code generation failed: FATAL: role "postgres" does not exist
   
   This caused unrelated compile errors for missing 
org.apache.texera.dao.jooq.generated classes.
   
   No new tests were added because this is a single-method resource lifecycle 
fix and existing dataset deletion paths already exercise this code.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: ChatGPT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to