PG1204 commented on PR #5626: URL: https://github.com/apache/texera/pull/5626#issuecomment-4695564029
> Clean, well-scoped cleanup. Moving the shared setup into one file means the two test files can't slowly fall out of sync, and routing the mouse tests into a `.browser.spec.ts` file is the right way to kill the double-run — bonus that six dead commented-out tests now actually run. > > One note: the diff also changes real app code in `workflow-editor.component.ts` (an optional `validation` param) that isn't in the description. Correct and harmless, but it makes a test-only PR not quite test-only — I'd surface it or split it out. Nothing blocking otherwise. I've chosen to split it out of this PR. Will raise it in a follow up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
