aglinxinyuan commented on code in PR #5659:
URL: https://github.com/apache/texera/pull/5659#discussion_r3406963073
##########
common/config/build.sbt:
##########
@@ -50,5 +50,6 @@ Compile / scalacOptions ++= Seq(
// Core Dependencies
libraryDependencies ++= Seq(
- "com.typesafe" % "config" % "1.4.6" // For configuration management
+ "com.typesafe" % "config" % "1.4.6", // For configuration management
+ "org.scalatest" %% "scalatest" % "3.2.15" % Test // ScalaTest (for unit
tests)
Review Comment:
Good catch — it wasn't included. The module already emits jacoco XML (root
`build.sbt` applies `coverageReportSettings` to every project via
`asfLicensingSettings`), and the amber job's Codecov upload globs
(`./**/target/scala-2.13/jacoco/report/jacoco.xml`,
`./**/target/test-reports/*.xml`) would pick it up — but the amber job's sbt
invocation deliberately skipped `Config/jacoco` because the module had no tests
("Modules with no tests (Config) are skipped"), so the new spec wouldn't have
run in CI at all.
Fixed in 2d276804d6 — added `Config/jacoco` to the amber job's test step and
dropped the now-stale comment. Verified locally that `sbt Config/jacoco` runs
the 16 specs and writes
`common/config/target/scala-2.13/jacoco/report/jacoco.xml` exactly where the
upload glob looks. Side effect: touching `build.yml` adds the `ci` label, so
this PR now runs the full stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
