Ma77Ball commented on code in PR #5545:
URL: https://github.com/apache/texera/pull/5545#discussion_r3407282404
##########
config-service/src/main/scala/org/apache/texera/service/resource/ConfigResource.scala:
##########
@@ -22,6 +22,7 @@ package org.apache.texera.service.resource
import jakarta.annotation.security.{PermitAll, RolesAllowed}
import jakarta.ws.rs.core.MediaType
import jakarta.ws.rs.{GET, Path, Produces}
+import org.apache.texera.amber.config.ApplicationConfig
Review Comment:
Package rename is up as #5672.
##########
frontend/src/app/common/service/gui-config.service.ts:
##########
@@ -83,10 +85,11 @@ export class GuiConfigService {
*/
loadPostLogin(): Observable<Partial<GuiConfig>> {
const guiConfig$ =
this.http.get<GuiOnlyConfig>(`${AppSettings.getApiEndpoint()}/config/gui`);
+ const amberConfig$ =
this.http.get<AmberConfig>(`${AppSettings.getApiEndpoint()}/config/amber`);
const userSystemConfig$ =
this.http.get<UserSystemConfig>(`${AppSettings.getApiEndpoint()}/config/user-system`);
- return forkJoin([guiConfig$, userSystemConfig$]).pipe(
- tap(([guiConfig, userSystemConfig]) => {
- this.config = { ...this.config, ...guiConfig, ...userSystemConfig };
+ return forkJoin([guiConfig$, amberConfig$, userSystemConfig$]).pipe(
+ tap(([guiConfig, amberConfig, userSystemConfig]) => {
+ this.config = { ...this.config, ...guiConfig, ...amberConfig,
...userSystemConfig };
Review Comment:
Agreed. Keeping this PR scoped to batch-size; will preserve config source
(`this.config['amber'] = ...`) in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
