Yicong-Huang opened a new pull request, #5682: URL: https://github.com/apache/texera/pull/5682
### What changes were proposed in this PR? Drops the macOS-only `pyamber-state-materialization-mac` diagnostic job and the sqlite-backed `SqlCatalog` override it relied on. The two state-materialization e2e tests now run under the existing `amber-integration` ubuntu job, which already provisions postgres + iceberg catalog DB + MinIO + Lakekeeper and runs `pytest -m integration` as its last step. Concretely: | Before | After | | --- | --- | | `pyamber-state-materialization-mac` macOS job (build.yml:742) | deleted | | `SqlCatalog` (sqlite) injected in module fixture | real postgres-backed `JdbcCatalog`, matching `test_iceberg_document.py:45` | | Test discovered by an explicit `pytest -sv <path>` from that job | `@pytest.mark.integration` + picked up by `amber-integration`'s `pytest -m integration` | `StorageConfig.initialize` is wrapped in a session-autouse fixture (rather than called at module import time) so it co-exists with `test_iceberg_document.py`'s import-time `initialize` regardless of pytest collection order. The unit-style `test_process_start_channel_persists_produce_state_on_start_output` that the mac job also ran is untouched: it monkeypatches the output manager and is already picked up by the regular `pyamber` job's `pytest -m \"not integration\"` step. ### Any related issues, documentation, discussions? Closes #5681. ### How was this PR tested? Locally against the existing texera-dev infra (postgres on 5432 with `texera_iceberg_catalog` schema initialized via `sql/iceberg_postgres_catalog.sql`): ``` cd amber && pytest -m integration --junit-xml=/tmp/junit-integration.xml -sv # 3 passed, 502 deselected -- test_state_written_by_output_manager_is_replayed_by_reader, # test_state_table_persists_across_writer_close, # test_rest_catalog_round_trip ``` And the regular pyamber suite still green: ``` cd amber && pytest -m "not integration" -q # 502 passed, 3 deselected ``` In CI, the `amber-integration` job picks these tests up automatically because they're marked `@pytest.mark.integration`. The mac job is gone so PRs no longer pay for a separate macOS runner just for these two tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
