Yicong-Huang opened a new issue, #5691:
URL: https://github.com/apache/texera/issues/5691

   ### Task Summary
   
   `amber/dev-requirements.txt` already documents the intent: *"Test- and 
dev-only Python dependencies. Installed in CI after the LICENSE-binary snapshot 
is taken, so packages here never appear in pip-licenses output and never need 
to be tracked in LICENSE-binary / NOTICE-binary. Not installed by packaging."*
   
   Four test-only pins are currently in the wrong file 
(`amber/requirements.txt`):
   
   | Pin | Current | Issue |
   | --- | --- | --- |
   | `pytest==7.4.0` | `requirements.txt:24` | 48 of 49 usages live under 
`amber/src/test/python` — pure test dep |
   | `pytest-reraise==2.1.2` | `requirements.txt:33` | pytest plugin |
   | `pytest-timeout==2.2.0` | `requirements.txt:26` | pytest plugin |
   | `iniconfig==1.1.1` | `requirements.txt:22` | pytest transitive 
(auto-installed with pytest); never imported directly |
   
   Because they sit in `requirements.txt`, they leak into:
   
   - `amber/system-requirements-lock.txt` (PVE engine-deps tracker per its own 
header)
   - `amber/LICENSE-binary-python` (BSD 2-Clause / MIT entries)
   - Production Docker images (`bin/computing-unit-master.dockerfile`, 
`bin/computing-unit-worker.dockerfile` install `requirements.txt`)
   
   Production images don't need pytest; PVE user venvs don't need pytest; only 
CI test stacks do — and CI already installs `dev-requirements.txt` separately.
   
   ### Scope
   
   | File | Change |
   | --- | --- |
   | `amber/requirements.txt` | drop `pytest`, `pytest-reraise`, 
`pytest-timeout`, `iniconfig` |
   | `amber/dev-requirements.txt` | add `pytest`, `pytest-reraise`, 
`pytest-timeout` (drop `iniconfig` — pytest transitive) |
   | `amber/system-requirements-lock.txt` | drop matching 4 lines |
   | `amber/LICENSE-binary-python` | drop matching 4 entries |
   
   ### Task Type
   
   - [x] Refactor / Cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to