Sentiaus commented on issue #4240: URL: https://github.com/apache/texera/issues/4240#issuecomment-4704219310
@aicam Sorry for the late response. Turns out I was completely mistaken, I was convinced the access token was needed to continue the resumable uploads. We get back a sessionURI from the resumable upload API, so we do not need to get another access token to do the resumable upload. To address your first point, we will: - No longer storing refresh tokens in the db. Access tokens were never stored. - Remove the `user_oauth_table` has been removed as it's no longer needed. - Remove TokenEncryptionService and any encryption logic, as we do not need to store tokens. - Remove checks for tokens and any drive disconnection logic. - "Connect to Drive" button will change to just "Export to Drive". On click, this will always start the Oauth Flow and grant the backend the access token. - The backend will then return the access token, and apiKey back to the UI I have two As to your second point: - We will stream data directly from MinIO - I do believe, as @chenlica mentioned as datasets may be up to 1 TB. While we don't need another access token to continue an upload, we would need to make a service to handle this. The previous pr just does a multipart upload (since the frontend would have the entire object at that point), but there isn't any logic in place to resume an upload in the case that anything fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
