Yicong-Huang commented on PR #5720:
URL: https://github.com/apache/texera/pull/5720#issuecomment-4704513635
had a discussion with @aglinxinyuan, two comments:
1. I think this property belongs to the physical execution and should be a
property of a physical op, not logical.
2. From the PR's perspective, it is not iideal to introduce a property
without having a consumer of the property. To keep the PR scope small, the
consumer can be simple. For instance, I assume this property should be consumed
by scheduler (?), so a logic like this
```
if any(physicalOp.requireMaterializedExecution):
// TODO: require non-pipeline mode
// original pipeline execution mode logic
.....
```
would be suffice. Note that this simple consumer can help reviewer to
understand how this property will be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
