carloea2 commented on code in PR #5603: URL: https://github.com/apache/texera/pull/5603#discussion_r3417930033
########## amber/src/test/python/pytexera/udf/test_udf_operator.py: ########## @@ -0,0 +1,194 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import datetime +from typing import Iterator, Optional + +import pytest + +from pytexera import AttributeType, Tuple, TupleLike, UDFOperatorV2 +from pytexera.udf.udf_operator import _UiParameterSupport + + +class InjectedParametersOperator(UDFOperatorV2): + def _texera_injected_ui_parameters(self): + return { + "count": "7", + "enabled": "1", + "created_at": "2024-01-01T00:00:00", + } + + def open(self): + self.count_parameter = self.UiParameter("count", AttributeType.INT) + self.enabled_parameter = self.UiParameter( + name="enabled", type=AttributeType.BOOL + ) + self.created_at_parameter = self.UiParameter( + "created_at", type=AttributeType.TIMESTAMP + ) + + def process_tuple(self, tuple_: Tuple, port: int) -> Iterator[Optional[TupleLike]]: + yield tuple_ + + +class ConflictingParameterOperator(UDFOperatorV2): + def _texera_injected_ui_parameters(self): + return {"duplicate": "1"} + + def open(self): + self.UiParameter("duplicate", AttributeType.INT) + self.UiParameter("duplicate", AttributeType.STRING) + + def process_tuple(self, tuple_: Tuple, port: int) -> Iterator[Optional[TupleLike]]: + yield tuple_ + + +class FirstIndependentParameterOperator(UDFOperatorV2): + def _texera_injected_ui_parameters(self): + return {"count": "1"} + + def open(self): + self.count_parameter = self.UiParameter("count", AttributeType.INT) + + def process_tuple(self, tuple_: Tuple, port: int) -> Iterator[Optional[TupleLike]]: + yield tuple_ + + +class SecondIndependentParameterOperator(UDFOperatorV2): + def _texera_injected_ui_parameters(self): + return {"count": "2"} + + def open(self): + self.count_parameter = self.UiParameter("count", AttributeType.INT) + + def process_tuple(self, tuple_: Tuple, port: int) -> Iterator[Optional[TupleLike]]: + yield tuple_ + + +class TestUiParameterSupport: Review Comment: Done. Added focused tests for the requested parsing and runtime edge cases, including Z timestamps, empty values, missing names, argument errors, and super().open() behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
