juliethecao commented on PR #5651: URL: https://github.com/apache/texera/pull/5651#issuecomment-4723804075
I tested these two changes (wrapping @mentions in backticks and fixing the pull_request_target job condition) on a test PR within my fork. However, pull_request_target does not fire for same-repo PRs as it only fires when a PR crosses from a fork into an upstream repo, which is the actual use case on apache/texera. To unblock local testing, I created a separate branch (cc-test-both-triggers) with pull_request added as a second trigger so the CI would fire on my fork. This workaround branch is not part of this official PR (which only keeps pull_request_target) and is only for local testing. Test PR results: https://github.com/juliethecao/texera/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
