mengw15 commented on code in PR #5258: URL: https://github.com/apache/texera/pull/5258#discussion_r3430685977
########## notebook-migration-service/src/main/resources/logback.xml: ########## @@ -0,0 +1,55 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +<configuration> + <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> Review Comment: Inconsistency: 5/6 existing services in this repo (agent-service, config-service, file-service, workflow-compiling-service, computing-unit-managing-service) configure logging only through the Dropwizard YAML — no separate logback.xml. Only access-control-service has both, which looks like a historical copy-paste. Dropwizard's official docs recommend against having both, since Dropwizard's YAML config reapplies logback configuration at startup and logback.xml becomes either dead weight or a source of duplicate appenders. Suggest dropping this logback.xml and keeping logging config solely in notebook-migration-service-web-config.yaml. Could you check on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
