kz930 commented on PR #5761:
URL: https://github.com/apache/texera/pull/5761#issuecomment-4736263084
Thanks for asking. There are two paths here:
1. Artifact exists: this PR’s own benchmark comment was posted
successfully by the updated workflow, so the normal `found=true` path still
works. In that path, the
artifact step sets `steps.artifact.outputs.found` to `true`, then `Unzip
artifact` and `Read PR number from artifact` run as before.
2. Artifact missing: the updated `github-script` step now sets
`found=false` before returning:
```js
core.setOutput("found", "false");
return;
The later steps are guarded with:
if: steps.artifact.outputs.found == 'true'
so when no bench-results-* artifact exists, the workflow emits the
existing warning and skips the unzip / PR-number steps instead of trying to
unzip a nonexistent file.
I also validated the workflow YAML locally with:
ruby -e 'require "yaml";
YAML.load_file(".github/workflows/benchmarks-pr-comment.yml"); puts "yaml ok"'
The current CI run also confirms the existing artifact-present path still
succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
