Copilot commented on code in PR #5809: URL: https://github.com/apache/texera/pull/5809#discussion_r3444967027
########## amber/operator-requirements.txt: ########## @@ -23,7 +23,7 @@ pybase64==1.3.2 # Pin torch to the CPU wheel on Linux x86_64 to avoid the NVIDIA CUDA deps. --extra-index-url https://download.pytorch.org/whl/cpu -torch==2.8.0+cpu ; platform_system == "Linux" and platform_machine == "x86_64" +torch==2.12.0+cpu ; platform_system == "Linux" and platform_machine == "x86_64" torch==2.8.0 ; platform_system != "Linux" or platform_machine != "x86_64" Review Comment: This change bumps the Linux x86_64 CPU wheel to 2.12.0+cpu, but the fallback requirement for other platforms still pins torch to 2.8.0. That leaves different torch versions depending on platform, and it doesn’t match the PR title/description (“bump torch from 2.8.0 to 2.12.0+cpu”). If the intent is to upgrade torch overall, bump the non-Linux/non-x86_64 pin as well (or clarify with a comment why it must remain on 2.8.0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
