tanishqgandhi1908 commented on code in PR #5799: URL: https://github.com/apache/texera/pull/5799#discussion_r3445480318
########## common/workflow-core/src/test/scala/org/apache/texera/amber/util/serde/PortIdentityKeySerializerSpec.scala: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.util.serde + +import org.apache.texera.amber.core.workflow.PortIdentity +import org.apache.texera.amber.util.JSONUtils.objectMapper +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.matchers.should.Matchers + +class PortIdentityKeySerializerSpec extends AnyFlatSpec with Matchers { + + "PortIdentityKeySerializer.portIdToString" should "format PortIdentity as id_internal" in { + PortIdentityKeySerializer + .portIdToString(PortIdentity(3, internal = false)) shouldBe "3_false" + PortIdentityKeySerializer + .portIdToString(PortIdentity(0, internal = true)) shouldBe "0_true" + } Review Comment: Resolved. The overlap was with the pre-existing combined PortIdentitySerdeSpec, which also predates the per-class spec convention requested in #5776. I deleted that older spec so this is now the single source of truth for the serializer-side coverage (portIdToString format + Jackson map-key output). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
