aglinxinyuan opened a new pull request, #5831: URL: https://github.com/apache/texera/pull/5831
### What changes were proposed in this PR? Pin behavior of three previously-untested visualization `PythonOperatorDescriptor`s in `common/workflow-operator/`. No production-code changes. | Spec | Source class | Tests | | --- | --- | --- | | `ContourPlotOpDescSpec` | `ContourPlotOpDesc` | 4 | | `PolarChartOpDescSpec` | `PolarChartOpDesc` | 5 | | `StripChartOpDescSpec` | `StripChartOpDesc` | 5 | **Behavior pinned** | Surface | Contract | | --- | --- | | `operatorInfo` | exact name + visualization group (Scientific / Scientific / Statistical); one input / one output | | `getOutputSchemas` | single `html-content` STRING column, asserted as the **full map keyed by `operatorInfo.outputPorts.head.id`** (input map ignored — `Map.empty` proves it) | | Field defaults | ContourPlot `x/y/z/gridSize == ""`, `connectGaps == false`; Polar `r/theta == ""`; Strip `x/y/colorBy/facetColumn == ""` | | `generatePythonCode` | Polar emits `go.Scatterpolargl(`; Strip emits `px.strip(` (structural Python only) | | Round-trip | all column fields preserved through the polymorphic base | **Notes for reviewers** - `ContourPlotOpDesc.generatePythonCode` is intentionally **not** exercised: a freshly-constructed instance has a `null` `coloringMethod` var, so codegen throws an NPE (the `@NotNull` is validation-layer only, not enforced at codegen). The spec pins the clean, deterministic contracts instead. - Codegen assertions check only structural Python (class def / import / plotly call) — never the interpolated `EncodableString` column values, which are base64-encoded at `.encode` time and do not appear literally. ### Any related issues, documentation, discussions? Closes #5828. ### How was this PR tested? - `sbt "WorkflowOperator/testOnly org.apache.texera.amber.operator.visualization.contourPlot.ContourPlotOpDescSpec org.apache.texera.amber.operator.visualization.polarChart.PolarChartOpDescSpec org.apache.texera.amber.operator.visualization.stripChart.StripChartOpDescSpec"` — 14 tests, all green - `sbt "WorkflowOperator/Test/scalafmtCheck"` and `sbt "WorkflowOperator/Test/scalafix --check"` — clean - CI to confirm ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8 [1M context]) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
