aglinxinyuan opened a new pull request, #5832:
URL: https://github.com/apache/texera/pull/5832
### What changes were proposed in this PR?
Pin behavior of three core operator-metadata types in
`common/workflow-operator/` — the data/trait types every `LogicalOp` relies on
for port wiring and metadata. No production-code changes.
| Spec | Source class | Tests |
| --- | --- | --- |
| `OperatorInfoSpec` | `OperatorInfo` (case class) | 4 |
| `PortDescriptionSpec` | `PortDescription` (case class) | 5 |
| `PortDescriptorSpec` | `PortDescriptor` (trait) | 2 |
**Behavior pinned**
| Surface | Contract |
| --- | --- |
| `OperatorInfo` fields | constructor field exposure; the four boolean flags
default to `false` and round-trip `true` when set; value equality |
| `OperatorInfo.forVisualization` | `inputPorts ==
List(InputPort(disallowMultiLinks = true))`, `outputPorts ==
List(OutputPort(mode = SINGLE_SNAPSHOT))` |
| `PortDescription` | field exposure; `dependencies` defaults `List.empty` +
accepts explicit deps; value equality + `copy`;
`@JsonIgnoreProperties("allowMultiInputs")` backward-compat marker (verified
via reflection) |
| `PortDescriptor` (trait) | `inputPorts`/`outputPorts` default to `null`
(not empty) and are reassignable |
**Note for reviewers:** scoped to the pure case-class/trait types only. The
`OperatorMetadataGenerator` object in the same file is deliberately **not**
tested — it eagerly reflects over the entire `LogicalOp` registry at init
(instantiating every descriptor), which is not pure-unit-testable.
### Any related issues, documentation, discussions?
Closes #5829.
### How was this PR tested?
- `sbt "WorkflowOperator/testOnly
org.apache.texera.amber.operator.metadata.OperatorInfoSpec
org.apache.texera.amber.operator.PortDescriptionSpec
org.apache.texera.amber.operator.PortDescriptorSpec"` — 11 tests, all green
- `sbt "WorkflowOperator/Test/scalafmtCheck"` and `sbt
"WorkflowOperator/Test/scalafix --check"` — clean
- CI to confirm
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
