aglinxinyuan commented on code in PR #5900:
URL: https://github.com/apache/texera/pull/5900#discussion_r3457099049
##########
common/workflow-core/src/test/scala/org/apache/texera/amber/storage/result/iceberg/IcebergDocumentSpec.scala:
##########
@@ -220,7 +220,7 @@ class IcebergDocumentSpec extends
VirtualDocumentSpec[Tuple] with BeforeAndAfter
val writer = stateDocument.writer(UUID.randomUUID().toString)
writer.open()
- writer.putOne(state.toTuple)
+ writer.putOne(state.toTuple())
Review Comment:
Done — renamed the user key `loop_counter` → `i`, and the test now writes
the loop bookkeeping via `toTuple(loopCounter = 7L, …)` and asserts the
dedicated `loop_counter`/`loop_start_id`/`loop_start_state_uri` columns on the
stored row (`getField`), instead of a JSON key. (`db66a7f`)
##########
common/workflow-core/src/test/scala/org/apache/texera/amber/storage/result/iceberg/IcebergDocumentSpec.scala:
##########
@@ -252,7 +252,7 @@ class IcebergDocumentSpec extends
VirtualDocumentSpec[Tuple] with BeforeAndAfter
val writer = stateDocument.writer(UUID.randomUUID().toString)
writer.open()
- states.foreach(state => writer.putOne(state.toTuple))
+ states.foreach(state => writer.putOne(state.toTuple()))
writer.close()
Review Comment:
Done — same fix: dropped `loop_counter` as a user key, set the counter via
`toTuple(loopCounter)`, and now sort/assert on the dedicated `loop_counter`
column (`getField`) while round-tripping user state (`i`/`payload`/`nested`)
through content. (`db66a7f`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
