Ma77Ball opened a new pull request, #5903:
URL: https://github.com/apache/texera/pull/5903

   ### What changes were proposed in this PR?
   - Backport of #5888 to `release/v1.2`, applied as `git cherry-pick -x 
8803d084c`.
   - Each amber e2e suite now gets a distinct id via a new 
`TestUtils.workflowContext(id, ...)` helper (DataProcessingSpec=1, PauseSpec=2, 
ReconfigurationSpec=3, ReconfigurationIntegrationSpec=4), and the DB fixture 
rows (user/workflow/version/execution, plus a per-id email) are derived from 
that id, so concurrent suites no longer collide in the shared Iceberg keyspace.
   - One conflict resolved, in `TestUtils.scala` imports only: kept 
release/v1.2's `org.apache.texera.amber.config.StorageConfig` path and took the 
cherry-pick's added `ExecutionIdentity`/`WorkflowIdentity`/`WorkflowSettings` 
imports needed by the new helper. The four spec files applied cleanly.
   - The `runWorkflowAndReadTerminalResults`/`readMaterializedResults` helpers 
that exist on `main` came from a separate change not on `release/v1.2`; #5888 
does not touch them, so they are correctly absent here.
   ### Any related issues, documentation, discussions?
   Closes: #5902
   ### How was this PR tested?
   - Behavior is unchanged from #5888 (test-only isolation), so it relies on 
the existing e2e suites carried over verbatim. Reviewer can run them in the 
integration job: `sbt "amber/IntegrationTest/testOnly 
*ReconfigurationIntegrationSpec"`, and the unit e2e suites via `sbt 
"amber/testOnly *DataProcessingSpec *PauseSpec *ReconfigurationSpec"`; expect 
all green with no Iceberg `CommitFailedException` keyspace collisions across 
concurrently-running suites.
   - Local `sbt` could not load on `release/v1.2` (its `project/` lacks 
`AddMetaInfLicenseFiles`, unrelated to this change), so full compile/test is 
left to CI on this PR.
   ### Was this PR authored or co-authored using generative AI tooling?
   Co-authored with Claude Opus 4.8 in compliance with ASF
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to