tanishqgandhi1908 commented on PR #5896: URL: https://github.com/apache/texera/pull/5896#issuecomment-4783976249
> maybe a bit more to ask, but can we hide the `Attribute` input box when `count(*)` is selected? > > alternatively, you can add a `*` value in `Attribute` so that its semantic is `func: count, value: "*"`. Thanks! Quick reasoning on both, and happy to change either: I disabled (greyed out) the Attribute instead of hiding it so the rows don't change height/jump when switching functions, the layout stays consistent. But hiding is a one-line change can do if team prefers it. The Attribute box is a single column-picker shared by every row and filled from the input schema. If we add a * option to it, that * would also show up for sum, min, max, etc, since the dropdown is the same for all functions. Limiting * to count only would need extra per-row conditional logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
