Yicong-Huang commented on code in PR #5743:
URL: https://github.com/apache/texera/pull/5743#discussion_r3464119484


##########
config-service/src/main/scala/org/apache/texera/service/ConfigService.scala:
##########
@@ -72,6 +74,8 @@ class ConfigService extends 
Application[ConfigServiceConfiguration] with LazyLog
 
     environment.jersey.register(new ConfigResource)
 
+    ConfigService.enforceRoleAnnotations(environment)

Review Comment:
   thanks for both points. as the current solution only checks once at service 
start up, it is good enough. compilation time check can help developers better 
because they could be alerted earlier, but that's good to have. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to