aglinxinyuan opened a new pull request, #5923:
URL: https://github.com/apache/texera/pull/5923
### What changes were proposed in this PR?
Pin behavior of three previously-untested SQL source descriptors in
`common/workflow-operator`. No production-code changes.
| Spec | Source class | Tests |
| --- | --- | --- |
| `MySQLSourceOpDescSpec` | `MySQLSourceOpDesc` | 5 |
| `PostgreSQLSourceOpDescSpec` | `PostgreSQLSourceOpDesc` | 5 |
| `AsterixDBSourceOpDescSpec` | `AsterixDBSourceOpDesc` | 5 |
**Behavior pinned**
| Surface | Contract |
| --- | --- |
| `operatorInfo` | exact name + description; Database Connector group; 0
inputs / 1 output |
| field defaults | runtime defaults (host/port/etc. `null`, `limit`/`offset`
`None`, `keywordSearch`/`progressive` `Some(false)`, `interval` `0L`);
AsterixDB geo/regex/filter toggles default `Some(false)` with empty lists |
| `sourceSchema()` | `null` before a connection is configured (IO-free
short-circuit) |
| `getPhysicalOp` | wires `OpExecWithClassName` for the matching `*OpExec`,
no input port / one output port, IO-free (lazy schema closure) |
| Round-trip | config fields preserved through the polymorphic `LogicalOp`
base; AsterixDB drops `username`/`password` via `@JsonIgnoreProperties` |
Note: `MySQLSourceOpDesc` is `@deprecated` (no longer executable) but
retained so legacy workflows still deserialize; the spec is annotated
`@nowarn("cat=deprecation")` and pins that backward-compatible contract.
### Any related issues, documentation, discussions?
Part of the ongoing `workflow-operator` unit-test coverage effort.
### How was this PR tested?
- `sbt "WorkflowOperator/testOnly *MySQLSourceOpDescSpec
*PostgreSQLSourceOpDescSpec *AsterixDBSourceOpDescSpec"` — 15 tests, all green
- `sbt "WorkflowOperator/Test/scalafmtCheck"` and `sbt
"WorkflowOperator/scalafixAll --check"` — clean
- CI to confirm
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
