zyratlo commented on code in PR #5260: URL: https://github.com/apache/texera/pull/5260#discussion_r3468849047
########## frontend/src/app/workspace/service/notebook-migration/migration-llm.spec.ts: ########## @@ -0,0 +1,232 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { NotebookMigrationLLM, Notebook } from "./migration-llm"; +import { GuiConfigService } from "../../../common/service/gui-config.service"; +import { WorkflowUtilService } from "../workflow-graph/util/workflow-util.service"; +import { generateText } from "ai"; +import type { Mock } from "vitest"; + +// The LLM transport and OpenAI client are mocked so the tests exercise only the +// deterministic transformation (parsing, operator/edge construction, cell<->operator mapping). +vi.mock("ai", () => ({ generateText: vi.fn() })); +vi.mock("@ai-sdk/openai", () => ({ + createOpenAI: vi.fn(() => ({ chat: vi.fn(() => ({})) })), +})); + +const mockGenerateText = generateText as unknown as Mock; + +describe("NotebookMigrationLLM", () => { + let opIdCounter = 0; + let stubUtil: WorkflowUtilService; + + // Build a fresh, initialized session with stubbed dependencies. The stubbed + // getNewOperatorPredicate hands out deterministic ids (PythonUDFV2-0, -1, ...). + function makeLLM(): NotebookMigrationLLM { + const stubConfig = { + env: { pythonNotebookMigrationEnabled: true }, + } as unknown as GuiConfigService; + + stubUtil = { + getNewOperatorPredicate: vi.fn((operatorType: string, customDisplayName?: string) => ({ + operatorID: `${operatorType}-${opIdCounter++}`, + operatorType, + operatorVersion: "test-version", + operatorProperties: { workers: 1, defaultEnv: true, envName: "" }, + inputPorts: [{ portID: "input-0", disallowMultiInputs: false }], + outputPorts: [{ portID: "output-0" }], + showAdvanced: false, + isDisabled: false, + customDisplayName, + dynamicInputPorts: true, + dynamicOutputPorts: true, + })), + } as unknown as WorkflowUtilService; + + const llm = new NotebookMigrationLLM(stubConfig, stubUtil); + llm.initialize(); + return llm; Review Comment: Refactored in [4bb8623](https://github.com/apache/texera/pull/5260/commits/4bb8623e8c129c46869b46d0f4ceaac8bb9073c9). See https://github.com/apache/texera/pull/5260#discussion_r3468842418 for more details -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
