Copilot commented on code in PR #5958:
URL: https://github.com/apache/texera/pull/5958#discussion_r3484671487
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/scheduling/RegionExecutionCoordinator.scala:
##########
@@ -97,7 +106,9 @@ class RegionExecutionCoordinator(
asyncRPCClient: AsyncRPCClient,
controllerConfig: ControllerConfig,
actorService: PekkoActorService,
- actorRefService: PekkoActorRefMappingService
+ actorRefService: PekkoActorRefMappingService,
+ maxTerminationAttempts: Int =
RegionExecutionCoordinator.DefaultMaxTerminationAttempts,
+ killRetryDelay: TwitterDuration =
RegionExecutionCoordinator.DefaultKillRetryDelay
) extends AmberLogging {
Review Comment:
The new termination-retry knobs are constructor parameters but are not
validated. If `maxTerminationAttempts <= 0` the coordinator will fail
immediately (or behave unexpectedly), and a negative `killRetryDelay` can lead
to confusing retry scheduling behavior. Add explicit `require` checks so
misconfiguration fails fast with a clear message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
