carloea2 commented on PR #5962:
URL: https://github.com/apache/texera/pull/5962#issuecomment-4827390136

   Thanks for working on this.
   
   Would you mind splitting the dataset and workflow fixes into separate PRs? 
They share the same root cause, but they touch different query builders and the 
workflow case is more complex because it also includes project access.
   
   I suggest:
   - PR 1: dataset duplicate fix only in `DatasetSearchQueryBuilder.scala`
   - PR 2: workflow duplicate fix only in `WorkflowSearchQueryBuilder.scala`
   
   For the first PR, please use `Refs #5957` instead of `Fixes #5957`, so the 
issue stays open until the workflow side is fixed too.
   
   Also, let’s keep the changes focused on the duplicate-row issue and avoid 
unrelated changes such as `ownerName` / `ownerUid` fallback defaults unless is 
mandatory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to