Ma77Ball opened a new pull request, #5989:
URL: https://github.com/apache/texera/pull/5989

   ### What changes were proposed in this PR?
   - Added `Partitioner.build_receiver_batches(channels)` to the base class, 
the single home for the ordered `(receiver, batch)` list built via 
`dict.fromkeys` (which preserves channel order where a set literal would not).
   - Replaced the three identical inline copies of that construction in 
`RoundRobinPartitioner`, `HashBasedShufflePartitioner`, and 
`RangeBasedShufflePartitioner` with a call to the shared helper, dropping the 
drifted copy-pasted comments.
   - No behavior change: each partitioner still builds the same ordered, 
deduplicated receiver list.
   ### Any related issues, documentation, discussions?
   Closes: #5988
   ### How was this PR tested?
   - Run `cd amber && PYTHONPATH=src/main/python python -m pytest 
src/test/python/core/architecture/sendsemantics/test_partitioners.py -q`, 
expect all 35 tests to pass.
   - The order/dedup behavior owned by the new helper is covered by the 
existing `TestRoundRobinPartitioner::test_init_preserves_channel_order` and 
`test_init_dedupes_duplicate_channels_preserving_first_seen_order`; confirm 
they still pass against the refactored construction.
   ### Was this PR authored or co-authored using generative AI tooling?
   Co-authored with Claude Opus 4.8 in compliance with ASF
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to