aglinxinyuan opened a new pull request, #6000:
URL: https://github.com/apache/texera/pull/6000

   ### What changes were proposed in this PR?
   
   Pin behavior of three previously-untested filter/dictionary value & enum 
types in `common/workflow-operator`. No production-code changes.
   
   | Spec | Source class | Tests |
   | --- | --- | --- |
   | `ComparisonTypeSpec` | `ComparisonType` | 4 |
   | `MatchingTypeSpec` | `MatchingType` | 2 |
   | `FilterPredicateSpec` | `FilterPredicate` | 6 |
   
   **Behavior pinned**
   
   | Surface | Contract |
   | --- | --- |
   | `ComparisonType` | the 8 constants → wire symbols (`=`, `>`, `>=`, `<`, 
`<=`, `!=`, `is null`, `is not null`); `fromString` case-insensitive + 
unknown-symbol rejection; Jackson `@JsonValue` round-trip |
   | `MatchingType` | the 3 constants → `Scan`/`Substring`/`Conjunction`; 
Jackson round-trip |
   | `FilterPredicate` | constructor fields; `equals`/`hashCode`; Jackson 
round-trip (`condition` as its symbol); `evaluate` over numeric, string, and 
null-check conditions against a `Tuple` |
   
   ### Any related issues, documentation, discussions?
   
   Part of the ongoing `workflow-operator` unit-test coverage effort.
   
   ### How was this PR tested?
   
   - `sbt "WorkflowOperator/testOnly *ComparisonTypeSpec *MatchingTypeSpec 
*FilterPredicateSpec"` — 12 tests, all green
   - `sbt "WorkflowOperator/Test/scalafmtCheck"` and `sbt 
"WorkflowOperator/scalafixAll --check"` — clean
   - CI to confirm
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to