Yicong-Huang opened a new issue, #6005:
URL: https://github.com/apache/texera/issues/6005

   ### Task Summary
   
   The nine per-service Dockerfiles currently live at `bin/*.dockerfile`, 
intermixed with general-purpose dev/CI scripts and helpers (`build-images.sh`, 
`local-dev.sh`, `single-node/`, etc.). They aren't really "tooling" — they're 
release artifacts that get built into `ghcr.io/apache/texera-*` images and 
consumed by `bin/single-node/docker-compose.yml` + `bin/k8s/`.
   
   Move them to a dedicated top-level `deployment/` folder so `bin/` stays 
focused on scripts:
   
   ```
   bin/                                deployment/
   ├── access-control-service.dockerfile      ──→  
access-control-service.dockerfile
   ├── agent-service.dockerfile               ──→  agent-service.dockerfile
   ├── computing-unit-master.dockerfile       ──→  
computing-unit-master.dockerfile
   ├── computing-unit-worker.dockerfile       ──→  
computing-unit-worker.dockerfile
   ├── config-service.dockerfile              ──→  config-service.dockerfile
   ├── file-service.dockerfile                ──→  file-service.dockerfile
   ├── texera-web-application.dockerfile      ──→  
texera-web-application.dockerfile
   ├── workflow-compiling-service.dockerfile  ──→  
workflow-compiling-service.dockerfile
   └── workflow-computing-unit-managing-service.dockerfile
                                              ──→  
workflow-computing-unit-managing-service.dockerfile
   ```
   
   `bin/pylsp/Dockerfile` and `bin/y-websocket-server/Dockerfile` stay where 
they are — those are inside service source trees (their `COPY` statements 
reference adjacent files), not standalone deployment artifacts.
   
   Refs that need to follow the move:
   
   * `bin/build-images.sh` line 108: `cd "$(dirname "$0")"` (cd's into `bin/`) 
→ cd into `deployment/`.
   * `.github/workflows/build-and-push-images.yml` line 215: `cd bin` → `cd 
deployment`.
   * `.github/workflows/build-and-push-images.yml` line 250: 
`dockerfile="bin/${service}.dockerfile"` → 
`dockerfile="deployment/${service}.dockerfile"`.
   * `bin/README.md` lines 7-12: path references in the build-from-source 
instructions.
   
   Pure structural move. Build context stays the repo root (every dockerfile 
already builds from `..` / repo root via `COPY` paths anchored at the top). No 
image-name changes, no compose / k8s value changes, no test changes.
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   - [x] DevOps / Deployment / CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to