Amer-Mukhtar opened a new pull request, #6035: URL: https://github.com/apache/texera/pull/6035
What changes were proposed in this PR? The Admin pages (Users, Executions, Gmail, Settings) rendered at inconsistent heights. On sections whose content exceeds the viewport, such as Settings and Users with many rows, the whole page grew and a document-level scrollbar appeared, which shifted the top nav and search bar. Switching between admin sections moved the nav buttons vertically, so the user had to reposition the cursor to click them. The cause is that the shared content area nz-content in dashboard.component.scss is a flex child with the default min-height of auto, so instead of scrolling internally it expanded to fit its content and pushed the layout, making the page height vary per section. The fix makes nz-content a bounded flex scroll container, so overflowing content scrolls inside the content area while the sidebar and top nav stay fixed and the page height stays consistent across all admin pages. The nz-content rule now adds min-height: 0 and flex: 1 alongside the existing overflow-y: auto. This is a CSS-only change. | Before | After | | --- | --- | | <img width="430" src="https://github.com/user-attachments/assets/3e4e4556-9b79-463b-b659-1a43bc7cf0aa"; /> | <img width="430" src="https://github.com/user-attachments/assets/c813943f-0c9a-4df1-ac7b-51741ab0bbf4"; /> | | <img width="430" src="https://github.com/user-attachments/assets/2b5b0041-1a55-40ec-bcb6-8036aeae1981"; /> | <img width="430" src="https://github.com/user-attachments/assets/818c4a7b-713c-4acd-aed8-7962e2b4ae76"; /> | | <img width="430" src="https://github.com/user-attachments/assets/0af1656b-afe1-4867-90ed-13d4517fe91b"; /> | <img width="430" src="https://github.com/user-attachments/assets/f81f5b6c-d39e-45e2-8528-be82b005f75b"; /> | | <img width="430" src="https://github.com/user-attachments/assets/c618cdaf-a28c-4640-9945-3359413a4f75"; /> | <img width="430" src="https://github.com/user-attachments/assets/f2d1eae3-0bfc-4743-8b24-d4a841b6009f"; /> | After: (drag after screenshot here) ### Any related issues, documentation, discussions? Closes #3588 ### How was this PR tested? Tested manually 1. Opened each admin page (Users, Executions, Gmail, Settings) and confirmed the page height and the top nav and search bar no longer shift between sections. 2. Verified the Users page with both few and many rows: content now scrolls within the content area instead of growing the whole page. 3. Spot-checked other dashboard pages (Workflows, Datasets) to confirm no scrolling regressions from the shared nz-content change. Was this PR authored or co-authored using generative AI tooling? Na -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
