carloea2 commented on PR #6016: URL: https://github.com/apache/texera/pull/6016#issuecomment-4846745433
Manual checks are useful, but this needs an automated DB-backed regression spec. Take a look at: `amber/src/test/scala/org/apache/texera/web/resource/dashboard/file/WorkflowResourceSpec.scala` That spec already uses `MockTexeraDB` from: `common/dao/src/test/scala/org/apache/texera/dao/MockTexeraDB.scala` Please add a regression test under `amber/src/test/scala/org/apache/texera/web/resource/dashboard/`, for example `DatasetSearchQueryBuilderSpec.scala`, using `MockTexeraDB`. - creates a public dataset owned by one user - adds a `DATASET_USER_ACCESS` row for the searching user - calls `dashboardResource.searchAllResourcesCall(..., SearchQueryParams(resourceType = "dataset"), includePublic = true)` - asserts the result contains exactly one dataset row for that `did` - asserts `accessPrivilege` is the searching user’s privilege -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
