Copilot commented on code in PR #6044: URL: https://github.com/apache/texera/pull/6044#discussion_r3502719866
########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/machineLearning/Scorer/classificationMetricsFncSpec.scala: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.machineLearning.Scorer + +import org.apache.texera.amber.util.JSONUtils.objectMapper +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.matchers.should.Matchers + +class classificationMetricsFncSpec extends AnyFlatSpec with Matchers { Review Comment: Spec class name is lowerCamelCase, which is inconsistent with the rest of the Scala test suite in this module and makes the type harder to discover in IDE/test reports. Rename the class to UpperCamelCase (and ideally rename the file to match). ########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/machineLearning/Scorer/regressionMetricsFncSpec.scala: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.machineLearning.Scorer + +import org.apache.texera.amber.util.JSONUtils.objectMapper +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.matchers.should.Matchers + +class regressionMetricsFncSpec extends AnyFlatSpec with Matchers { Review Comment: Spec class name is lowerCamelCase, which is inconsistent with the rest of the Scala test suite in this module (e.g., MachineLearningScorerOpDescSpec) and makes the type harder to discover in IDE/test reports. Rename the class to UpperCamelCase (and ideally rename the file to match). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
