Yicong-Huang commented on code in PR #6037:
URL: https://github.com/apache/texera/pull/6037#discussion_r3504495314
##########
amber/src/main/scala/org/apache/texera/amber/engine/common/rpc/AsyncRPCServer.scala:
##########
@@ -103,9 +103,9 @@ class AsyncRPCServer(
// if error occurs, return it to the sender.
logger.error("Exception occurred", err)
returnResult(senderID, id, mkControlError(err))
- // if throw this exception right now, the above message might not be able
- // to be sent out. We do not throw for now.
- // throw err
+ // Re-throw Errors (e.g. failed assertions) after replying; only
+ // Exceptions are returned to the sender and recovered from.
+ if (err.isInstanceOf[Error]) throw err
Review Comment:
how come non errors can reach here? that's a bigger problem...
with your change, this "non-error" is omitted silently...
can we at least log warning when it happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
