Ma77Ball opened a new pull request, #6052:
URL: https://github.com/apache/texera/pull/6052

   ### What changes were proposed in this PR?
   - Delete `MySQLSourceOpExec` and `MySQLConnUtil`, the executor and JDBC 
connection helper for the deprecated MySQL source operator, which have been 
unreachable dead code since the `mysql-connector-java` driver was dropped in 
#4386.
   - Reduce `MySQLSourceOpDesc` to a deserialization-only stub: `getPhysicalOp` 
now throws `UnsupportedOperationException` instead of wiring the deleted 
executor, and the `MySQLConnUtil`-based `establishConn` override is removed, 
while its fields, `operatorInfo`, and `updatePort` remain so legacy workflows 
still deserialize.
   - Add a comment at the `LogicalOp` type registration noting the type is 
retained non-executable for legacy-workflow deserialization only.
   - Update `MySQLSourceOpDescSpec` (flip the `getPhysicalOp` case to assert it 
throws, keep the deserialization coverage) and delete `MySQLConnUtilSpec` along 
with the util it covered.
   ### Any related issues, documentation, discussions?
   Closes: #6051
   ### How was this PR tested?
   - Run `sbt "WorkflowOperator/testOnly *MySQLSourceOpDescSpec"` and expect 5 
tests passing, including the flipped case asserting `getPhysicalOp` throws 
`UnsupportedOperationException` and the round-trip test confirming a 
`MySQLSource` node still deserializes into a `MySQLSourceOpDesc`.
   - Note: tests were run locally under JDK 17; under JDK 25 the sbt-jacoco 
0.8.11 instrumentation step fails on a dependency class before any test runs, 
which is an environment/tooling limitation unrelated to this change.
   ### Was this PR authored or co-authored using generative AI tooling?
   Co-authored with Claude Opus 4.8 in compliance with ASF


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to