Yicong-Huang commented on code in PR #6031: URL: https://github.com/apache/texera/pull/6031#discussion_r3521400188
########## bin/local-dev/main.sh: ########## @@ -624,9 +763,13 @@ amap_set SVC_HEALTH frontend "" # --------- docker infra config --------- DOCKER_PROJECT="texera-local-dev" -DOCKER_COMPOSE_FILE="$REPO_ROOT/bin/single-node/docker-compose.yml" -DOCKER_OVERLAY_FILE="$REPO_ROOT/bin/local-dev/docker-compose.override.yml" -DOCKER_ENV_FILE="$REPO_ROOT/bin/single-node/.env" +# Infra orchestration is part of the tooling, not the deployed app — pin it to +# the self tree so a deployed worktree always comes up against main's known-good +# docker compose (the app schema/DDL it applies still comes from the source tree +# via $REPO_ROOT). +DOCKER_COMPOSE_FILE="$SELF_ROOT/bin/single-node/docker-compose.yml" +DOCKER_OVERLAY_FILE="$SELF_ROOT/bin/local-dev/docker-compose.override.yml" +DOCKER_ENV_FILE="$SELF_ROOT/bin/single-node/.env" Review Comment: Good catch — addressed in 2b1c7d554 with both suggestions: (1) `--help` and the TUI `h` help now document that the tooling always runs from this checkout, so a target modifying `bin/local-dev/**` needs its own `local-dev.sh`; (2) `up`/`auto` print a non-fatal warning when the target's `bin/local-dev/` differs from the self tree's (`diff -rq`). We intentionally don't diff `bin/single-node/` — changes there don't affect the local-dev stack (the overlay/env are part of the orchestration tooling). Covered by 4 new smoke-test checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
