aglinxinyuan opened a new pull request, #6083:
URL: https://github.com/apache/texera/pull/6083
### What changes were proposed in this PR?
Add unit test coverage for three `common/config` objects, selected from the
Codecov report (all 0%). No production-code changes.
| File | Codecov before | What the tests pin |
| --- | --- | --- |
| `EnvironmentalVariable.scala` | 0% | every env-var-name constant resolves,
is non-empty, and is unique; `get` returns `None`/`Some` for unset/set vars |
| `ApplicationConfig.scala` | 0% | every value resolves from
application.conf with its default (constants, flow-control, network-buffering,
reconfiguration, fault-tolerance, scheduling, cleanup, web-server,
ai-assistant) |
| `GuiConfig.scala` | 0% | every gui.conf boolean/string/int setting
resolves to its default |
Reading each value forces resolution from the backing `.conf`, so a renamed
or mistyped key surfaces here as a `ConfigException` instead of at service
start-up. Every key carries a `${?ENV}` override, so exact-value assertions are
guarded on the env var being unset — mirroring the existing `StorageConfigSpec`.
### Any related issues, documentation, discussions?
Follow-up to the review feedback on #6043: prioritize tests that fill
uncovered code paths.
### How was this PR tested?
- `sbt "Config/testOnly *EnvironmentalVariableSpec *ApplicationConfigSpec
*GuiConfigSpec"` — 16 tests, all green
- `sbt "Config/Test/scalafmtCheck"` and `sbt "Config/scalafixAll --check"` —
clean
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
