kunwp1 opened a new pull request, #6104: URL: https://github.com/apache/texera/pull/6104
### What changes were proposed in this PR? While testing the dknet-ai.org deployment (a downstream fork of Texera), we found the computing-unit creation modal complicated for non-technical users: every configuration is listed inline, and shared memory size / JVM memory size are too technical for most users, crowding the common path (name / RAM / CPU). This PR tucks those two knobs behind a collapsed "Advanced Settings" disclosure in the shared `ComputingUnitCreateModalComponent` (introduced by #6082), so both creation entry points — the dashboard Computing Units page and the workspace power button — get the simplified default view. - Progressive disclosure: rotating chevron + smooth height animation (0fr→1fr grid-row transition, no hard-coded max-height); collapsed by default, and re-collapsed every time the modal opens (`ngOnChanges` on `visible`). - Validation stays visible: when the panel is collapsed and shared memory exceeds total memory, an amber "Shared memory exceeds total" hint is promoted onto the collapsed header so an invalid value cannot be submitted unseen; when valid, the header shows a "Shared memory · JVM heap size" hint to keep the options discoverable. - Accessibility: the toggle is a native `<button>` with `aria-expanded`, and the collapsed panel is `inert` so its controls stay out of the tab order. This feature was originally implemented and validated on the downstream deployment ([Texera/dknet-ai-public@30318e2d](https://github.com/Texera/dknet-ai-public/commit/30318e2da47aff5620997febdf2f92e54c92aad1), where the modal was still duplicated across the two hosts) and is re-applied here on top of the shared modal component. ### Any related issues, documentation, discussions? Closes #6102 ### How was this PR tested? Four unit tests were added to `computing-unit-create-modal.component.spec.ts` covering the panel toggle, the re-collapse-on-open behavior (and that closing does not touch panel state), and the collapsed-header warning in both the shm-too-large and shm-valid cases. Ran the modal suite plus both host suites: ``` cd frontend yarn test --include "**/computing-unit-create-modal.component.spec.ts" \ --include "**/computing-unit-selection.component.spec.ts" \ --include "**/user-computing-unit.component.spec.ts" ``` All 89 tests pass (3 files). `prettier-eslint --list-different` and `eslint` report no issues on the changed files. The UI behavior (collapsed default, animation, warning promotion, tab order) was validated interactively on the dknet-ai.org deployment where the feature originated. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code, Claude Opus 4.8 (original downstream implementation) and Claude Fable 5 (port onto the shared modal component) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
