aglinxinyuan opened a new issue, #6125: URL: https://github.com/apache/texera/issues/6125
### Task Summary Cache source operators were replaced by input-port materialization reader threads in #3425 (the symmetric follow-up to sink-operator removal in #3312). Since then `CacheSourceOpExec` has been **unreachable**: the scheduler no longer inserts a cache-source read op for a materialized link — it tags the downstream input port with the URI directly. `SpecialPhysicalOpFactory.newSourcePhysicalOp` — the only producer of an `OpExecSource` init-info, which is what constructs `CacheSourceOpExec` in `DataProcessorRPCHandlerInitializer.setupExecutor` — has **no production caller**; its only remaining references are its own spec. This is dead code and should be removed. Materialized-link read path, before → after: ``` Before (pre-#3425): upstream OutputPort(URI) ──► [CacheSourceOpExec] ──► downstream InputPort After (#3425+): upstream OutputPort(URI) ─────────────────────────► downstream InputPort(URI) ``` Removal scope: | Item | Location | Note | | --- | --- | --- | | `CacheSourceOpExec` | `common/workflow-operator/.../source/cache/CacheSourceOpExec.scala` | the executor | | `SpecialPhysicalOpFactory` (+ its spec) | `common/workflow-operator/.../operator/SpecialPhysicalOpFactory.scala` | sole producer of `OpExecSource`; no production caller | | `OpExecSource` match arm + import | `amber/.../worker/DataProcessorRPCHandlerInitializer.scala` (import L26, arm L92) | unreachable branch | | `OpExecSource` message + oneof field | `common/workflow-core/.../protobuf/.../executor.proto` (message L42, `opExecSource = 3` L51) | remove; **reserve field number `3`** in the `sealed_value` oneof to prevent reuse | Notes: - The `OpExecInitInfo` oneof is an internal controller↔worker wire format (built and consumed within the same deployment; `preserve_unknown_fields: false`), so dropping the field is safe — just reserve `3`. - The unit spec `CacheSourceOpExecSpec` was already dropped in #6098 (this dead-code discovery came out of that review), so nothing test-side blocks the removal. ### Task Type - [x] Refactor / Cleanup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
