aglinxinyuan commented on PR #6098: URL: https://github.com/apache/texera/pull/6098#issuecomment-4884397462
Good catch — no, we're not. Cache source operators were replaced by input-port materialization reader threads in #3425. `SpecialPhysicalOpFactory.newSourcePhysicalOp` — the only producer of `OpExecSource`, which is what constructs `CacheSourceOpExec` in `DataProcessorRPCHandlerInitializer.setupExecutor` — no longer has any production caller, so both are effectively dead code. Dropped `CacheSourceOpExecSpec` from this PR in 19d4967 — no point covering a path that's on its way out. Filed #6125 to remove `CacheSourceOpExec` and the `OpExecSource` plumbing as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
