aglinxinyuan opened a new pull request, #6158:
URL: https://github.com/apache/texera/pull/6158

   ### What changes were proposed in this PR?
   
   Adds `EmbeddedControlMessageManagerSpec` (new) for the amber worker's 
`EmbeddedControlMessageManager`, which had no spec. Using directly-constructed 
collaborators (`NetworkInputGateway` + `InputManager`, no actor system), it 
covers the `isECMAligned` / `getChannelsWithinScope` branches:
   
   - `ALL_ALIGNMENT` (empty scope) — not aligned until every data channel has 
delivered the ECM;
   - `PORT_ALIGNMENT` — aligns on the port's channel set;
   - `NO_ALIGNMENT` — triggers only on the first ECM;
   - an unsupported ECM type throws `IllegalArgumentException`;
   - the non-empty-scope filter path.
   
   No production code changed.
   
   ### Any related issues, documentation, discussions?
   
   Coverage gaps identified from the Codecov report for `apache/texera` (amber 
module coverage push toward 80%).
   
   ### How was this PR tested?
   
   ```
   sbt "WorkflowExecutionService/testOnly *EmbeddedControlMessageManagerSpec"
   ```
   
   All 5 pass. `scalafmt` and `scalafixAll --check` are clean.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to