Copilot commented on code in PR #6225: URL: https://github.com/apache/texera/pull/6225#discussion_r3540260167
########## amber/build.sbt: ########## @@ -276,7 +276,7 @@ libraryDependencies += "com.konghq" % "unirest-java" % "3.14.5" libraryDependencies += "com.github.marianobarrios" % "lbmq" % "0.6.0" // https://mvnrepository.com/artifact/org.jooq/jooq -libraryDependencies += "org.jooq" % "jooq" % "3.14.16" +libraryDependencies += "org.jooq" % "jooq" % "3.21.6" Review Comment: This bumps runtime jOOQ to 3.21.6 in amber, but the repo still pins other jOOQ artifacts to 3.16.23 (e.g., common/dao/build.sbt and project/plugins.sbt jooq-codegen). Mixing jOOQ minor/major versions across modules can lead to dependency eviction surprises and potential binary incompatibilities at runtime or during codegen. Consider aligning jOOQ/jooq-codegen versions (ideally via a shared jooqVersion val) and updating any related pins (e.g., the pgjdbc constraint in project/plugins.sbt) accordingly. ########## computing-unit-managing-service/build.sbt: ########## @@ -47,7 +47,7 @@ libraryDependencies ++= Seq( "io.dropwizard" % "dropwizard-core" % dropwizardVersion, "io.dropwizard" % "dropwizard-auth" % dropwizardVersion, // Dropwizard Authentication module "io.kubernetes" % "client-java" % "21.0.0", - "org.jooq" % "jooq" % "3.14.16", + "org.jooq" % "jooq" % "3.21.6", Review Comment: This module is updated to jOOQ 3.21.6, but other parts of the build still use jOOQ 3.16.23 (common/dao/build.sbt) and jooq-codegen 3.16.23 (project/plugins.sbt). Having different jOOQ versions across sbt subprojects can cause eviction/classpath inconsistencies and makes it harder to reason about compatibility. Recommend aligning versions across the build (or centralizing a shared jooqVersion) before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
