Copilot commented on code in PR #6245:
URL: https://github.com/apache/texera/pull/6245#discussion_r3540309887
##########
amber/build.sbt:
##########
@@ -224,7 +224,7 @@ genPythonProto := {
"Install protoc and `pip install betterproto[compiler]` before
launching a Python worker or running pytest."
)
} else {
- val procLogger = scala.sys.process.ProcessLogger(line => log.info(line),
line => log.error(line))
+ val procLogger = scala.sys.process.ProcessLogger(line => log.info(line),
line => log.info(line))
Review Comment:
After routing both stdout and stderr to `info`, log output no longer
indicates whether a given line came from stderr. That makes it harder to
diagnose failures or warnings from `python-proto-gen.sh` (especially when the
task fails and only the final `sys.error(...)` is logged at error level).
Consider prefixing stderr lines so provenance is preserved while still avoiding
`[error]` output in IDEs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
