Yicong-Huang commented on code in PR #6130:
URL: https://github.com/apache/texera/pull/6130#discussion_r3561338469


##########
bin/single-node/nginx.conf:
##########
@@ -95,6 +95,12 @@ http {
             proxy_set_header Host $host;
         }
 
+        location /api/pve/ {
+            proxy_pass http://workflow-runtime-coordinator-service:8085;
+            proxy_set_header Host $host;
+            proxy_set_header X-Real-IP $remote_addr;
+        }

Review Comment:
   OK, is there a way we can document this " longest-prefix matching rather 
than first-match matching" next to the conf? 
   
   even though it is using `longest-prefix matching`, can we still move it up 
to be closer to other `/api/xxx` endpoints? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to