zuozhiw commented on PR #5375: URL: https://github.com/apache/texera/pull/5375#issuecomment-4965523545
> Approve the PR but left some comments. Please take a look and we can have a discussion. > > From my perspective I don't really care about flow charts or architecture diagrams, I care more like what API does this provide to developers when they want to add logging, tracing, and metrics. So if there's a description of that it would be nice, if I missed it please let me know. > > Also I only see a logging class being added. There are some trace and metrics related config, are we going to expose them as well? Ok I now see the trace and metrics related stuff are in second PR, I'll continue to review that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
