eugenegujing opened a new pull request, #6423: URL: https://github.com/apache/texera/pull/6423
### What changes were proposed in this PR? Adds `search-filter-parameters.spec.ts` to cover `toQueryStrings`, the previously untested pure query-string builder that every dashboard and hub search request flows through. The 17 tests pin the full contract with exact full-string assertions: one repeated `query` param per trimmed keyword, `YYYY-MM-DD` serialization of the four date filters, repeated `owner`/`id`/`operator`/`projectId` params, URL encoding of all values, the falsy-value drop (whitespace-only keywords, empty-string owners, `start=0`/`count=0` omitted while `projectId=0` is kept), `resourceType` emitted only for a non-null type, `orderBy` emitted via enum-name reverse lookup including `SortMethod.NameAsc` (enum value 0), and the end-to-end parameter emission order. The date assertions use 12:00 UTC-anchored Date literals so they produce the same `YYYY-MM-DD` output in every timezone, keeping the tests stable regardless of where they run. No production code was changed. ### Any related issues, documentation, discussions? Closes #6399 ### How was this PR tested? Added 17 new unit tests in search-filter-parameters.spec.ts. Ran locally via `yarn ng test --watch=false --include '**/dashboard/type/search-filter-parameters.spec.ts'`; all 17 pass, and also pass under TZ=Pacific/Kiritimati (UTC+14) and TZ=America/Anchorage (UTC-9). Neighboring search.service.spec.ts still passes (13/13); prettier and eslint are clean. ### Was this PR authored or co-authored using generative AI tooling? Co-authored using Claude (Anthropic). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
