Copilot commented on code in PR #6407: URL: https://github.com/apache/texera/pull/6407#discussion_r3583713854
########## amber/operator-requirements.txt: ########## @@ -22,7 +22,7 @@ pillow==12.2.0 # Pin torch to the CPU wheel on Linux x86_64 to avoid the NVIDIA CUDA deps. --extra-index-url https://download.pytorch.org/whl/cpu -torch==2.12.1+cpu ; platform_system == "Linux" and platform_machine == "x86_64" +torch==2.13.0+cpu ; platform_system == "Linux" and platform_machine == "x86_64" torch==2.12.1 ; platform_system != "Linux" or platform_machine != "x86_64" Review Comment: The PR title/description says torch is bumped, but the non-Linux/non-x86_64 pin is still `2.12.1`. This leaves different torch versions depending on platform and doesn’t fully reflect the stated bump; update the second constraint to `2.13.0` as well (without `+cpu`). ########## amber/operator-requirements.txt: ########## @@ -22,7 +22,7 @@ pillow==12.2.0 # Pin torch to the CPU wheel on Linux x86_64 to avoid the NVIDIA CUDA deps. --extra-index-url https://download.pytorch.org/whl/cpu -torch==2.12.1+cpu ; platform_system == "Linux" and platform_machine == "x86_64" +torch==2.13.0+cpu ; platform_system == "Linux" and platform_machine == "x86_64" torch==2.12.1 ; platform_system != "Linux" or platform_machine != "x86_64" Review Comment: Torch version changed here will also change the resolved installed package set, but amber/LICENSE-binary-python still lists `torch==2.12.1`. CI’s Python 3.12 binary-license drift check canonicalizes `+cpu` to the public version, so this likely needs an update to `torch==2.13.0` in that LICENSE manifest to keep the check passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
