aglinxinyuan commented on PR #6488: URL: https://github.com/apache/texera/pull/6488#issuecomment-5008791505
> can we take the chance to fill up those coverage? Done in f68aad006d — the winutils gate in `newLocalHadoopConf` is now injectable (defaults to the host's real winutils availability), so both branches, including the Windows-only override, are unit-tested on every platform. `setOwner` is covered too. The remaining unexecuted lines on Linux runs are the Windows-only arms of the runtime gate itself, which is exactly the Codecov gap a Windows leg would close. > do we also need to add a windows CI to prevent this from happening again? Agreed — that's the only thing that would have flagged #6201/#6227. Opened #6503 to track a minimal `windows-latest` leg: the regression test in this PR fails on a stock Windows runner without the fix, so even a small WorkflowCore-only job would have caught it. Kept it separate so this fix isn't blocked on CI-cost discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
