Copilot commented on code in PR #6622: URL: https://github.com/apache/texera/pull/6622#discussion_r3617779795
########## frontend/src/app/common/util/map.spec.ts: ########## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { mapToRecord, recordToMap } from "./map"; + +describe("mapToRecord", () => { + it("converts a populated Map into an equivalent plain record", () => { + const map = new Map<string, any>([ + ["a", 1], + ["b", "two"], + ["c", { nested: true }], + ]); + expect(mapToRecord(map)).toEqual({ a: 1, b: "two", c: { nested: true } }); + }); + + it("returns an empty object for an empty Map", () => { + expect(mapToRecord(new Map())).toEqual({}); + }); + + it("keeps the last value when JSON serialization would collapse it (order preserved on write)", () => { Review Comment: Test name is misleading: Maps cannot have duplicate keys, and this test does not assert any ordering behavior. Consider renaming it to describe the actual behavior under test (overwriting an existing key keeps the latest value). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
