mengw15 opened a new issue, #6825:
URL: https://github.com/apache/texera/issues/6825

   ### Task Summary
   
   `JointGraphWrapper` sits at codecov ~69% (90 uncovered lines). Goal: **cover 
the file's remaining unit-testable methods to bring its coverage toward 
complete** — the state layer needs no rendering, so construct the wrapper over 
a headless `new joint.dia.Graph()` (no `dia.Paper`) and exercise every method 
that doesn't require a Paper. The families below are the likely gap; cover 
whichever of them the spec doesn't already hit, plus any other non-rendering 
method. Only the geometry/Paper methods are out of scope. jsdom/Vitest; see 
`frontend/TESTING.md`.
   
   ### Behavior to add
   
   **JointGraphWrapper** 
(`frontend/src/app/workspace/service/workflow-graph/model/joint-graph-wrapper.ts`,
 codecov ~69% — EXTEND; cover all remaining non-rendering methods)
   
   - Highlighting: `highlightOperators` / `highlightLinks` / `highlightPorts` / 
`highlightCommentBoxes` and their `unhighlight*` — assert the current-highlight 
lists via `getCurrentHighlightedOperatorIDs` / `getCurrentHighlightedLinkIDs` / 
`getCurrentHighlightedPortIDs` / `getCurrentHighlightedCommentBoxIDs` / 
`getCurrentHighlights`, and that the matching `getJoint*HighlightStream` / 
`getJoint*UnhighlightStream` emits the id. Cover multi-select vs single-select 
(`setMultiSelectMode`).
   - Editing / property flags: `setCurrentEditing` / `removeCurrentEditing` / 
`setPropertyChanged` / `removePropertyChanged` / `setReloadingWorkflow` + 
`getReloadingWorkflow` / `setRegionsDisplayed` + `getRegionsDisplayed` (+ their 
streams) — assert the flag round-trips and emits.
   - Zoom: `setZoomProperty` / `getZoomRatio` / `isZoomRatioMax` / 
`isZoomRatioMin` / `restoreDefaultZoomAndOffset` — assert the ratio clamps at 
the min/max bounds and the zoom stream emits.
   - Breakpoints: `getLinkIDsWithBreakpoint` and the breakpoint show/hide 
streams after a highlight/unhighlight.
   
   Out of scope (need a real `dia.Paper` / geometry): `attachMainJointPaper` / 
`getMainJointPaper`, `autoLayoutJoint`, `getElementPosition` / 
`setElementPosition` / `setAbsolutePosition`, `restorePaperOffset` — leave to a 
browser-mode spec.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to