mengw15 opened a new pull request, #6832:
URL: https://github.com/apache/texera/pull/6832
### What changes were proposed in this PR?
Extends the existing `OperatorPropertyEditFrameComponent` spec (codecov
~72%) with
8 deterministic tests for the non-Quill methods it did not reach:
- **Modify-logic gating** — `allowModifyOperatorLogic`, and
`confirmModifyOperatorLogic`
across its three paths: applies the change and re-locks the form; surfaces
a thrown
error through `NotificationService` while leaving the form editable;
no-ops when no
operator is selected.
- **Subscription handlers** — the display-name handler retitles only the
current
operator; the workflow-modification handler mirrors the flag onto the
form's
interactivity and stays out of the way when no operator is selected; the
dynamic-schema handler re-renders only for the current operator.
- **`rerenderEditorForm`** — early return when no operator is selected.
Already-covered behaviour was deliberately not duplicated: the form-change →
`setOperatorProperty` path is covered by the existing "should change Texera
graph
property when the form is edited by the user" test, and `formatTaskTitle` /
`isHuggingFaceOperator` are exercised by the HuggingFace preview tests. The
Quill
binding stays out of scope per the issue. No production code was changed.
### Any related issues, documentation, discussions?
Closes #6826.
### How was this PR tested?
`ng test --watch=false --include
src/app/workspace/component/property-editor/operator-property-edit-frame/operator-property-edit-frame.component.spec.ts`
— 190 passed, 1 skipped, exit 0.
`eslint` exit 0 and `prettier --check` clean on the spec.
Failure path verified by breaking two of the new assertions and confirming a
non-zero exit, then restoring.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
