zyratlo commented on PR #5265: URL: https://github.com/apache/texera/pull/5265#issuecomment-5061651322
> > > Could you also add a screenshot of the frontend to the PR description? Thanks. Also is there a specific reason we put the button on the mini map? (for example do we want to put it on the top menu?) > > > > > > I added a screenshot. The placement of the button doesn't have a particular reason, that was just the most logical place we thought to put it at the time. The top menu has many buttons already so we didn't want to pollute it, but I am open to this change. What do you think? > > Semantically, I think placing the button on the minimap feels a bit unusual, so I would still prefer putting it in the top menu. I also think the current button icon is a little bit confusing Ok, I will make the change to move it to the top. In terms of the icon I can change it to the Jupyter logo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
